Skip to content

fix: migrate Schwab monitor schedulers safely - #278

Merged
Pigbibi merged 6 commits into
mainfrom
codex/fix-direct-monitors-20260728
Jul 29, 2026
Merged

fix: migrate Schwab monitor schedulers safely#278
Pigbibi merged 6 commits into
mainfrom
codex/fix-direct-monitors-20260728

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • select the current Cloud Run deploy target without losing authoritative per-service configuration
  • build the shared dispatcher payload from all enabled targets and per-target regions
  • stage direct /probe and /dry-run schedulers with target-specific pause/resume handling
  • require deployment markers, disabled-target safety, explicit cutover verification, and current-sync proof before legacy cleanup
  • reconcile Cloud Run traffic before cleanup and preserve rollback behavior

Verification

  • uv run --no-sync pytest -q — 198 passed
  • targeted pytest — 23 passed
  • Ruff, actionlint, uv lock check, and diff check passed
  • GitHub Codex review performed on each remediation head; exact findings addressed and resolved

Rollout

  1. Merge/deploy with migration and cutover flags unset; legacy dispatcher remains.
  2. Set DIRECT_MONITOR_MIGRATION_COMPLETE=true; deploy and verify both direct monitor jobs while dispatcher remains.
  3. After successful direct monitor requests, set DIRECT_MONITOR_CUTOVER_VERIFIED=true; rerun deploy and verify dispatcher cleanup.

No live /run endpoint was invoked.

Co-Authored-By: Codex <noreply@openai.com>

Pigbibi commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 272c14abe3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/reconcile_cloud_runtime.py Outdated
Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi

Pigbibi commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 87d4512fd4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/sync-cloud-run-env.yml Outdated
Comment thread scripts/reconcile_cloud_runtime.py Outdated
Co-Authored-By: Codex <noreply@openai.com>

Pigbibi commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b42af5014a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/reconcile_cloud_runtime.py Outdated
Comment thread scripts/reconcile_cloud_runtime.py Outdated
Co-Authored-By: Codex <noreply@openai.com>

Pigbibi commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4a6e014815

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/sync-cloud-run-env.yml Outdated
Comment thread scripts/reconcile_cloud_runtime.py Outdated
Comment thread .github/workflows/sync-cloud-run-env.yml
Comment thread scripts/build_cloud_run_env_sync_plan.py Outdated
Co-Authored-By: Codex <noreply@openai.com>

Pigbibi commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bb69519fae

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/reconcile_cloud_runtime.py
Co-Authored-By: Codex <noreply@openai.com>

Pigbibi commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: a51f1f06be

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Pigbibi

Pigbibi commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: a51f1f06be

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Pigbibi
Pigbibi merged commit aba8489 into main Jul 29, 2026
2 checks passed
@Pigbibi
Pigbibi deleted the codex/fix-direct-monitors-20260728 branch July 29, 2026 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant